[PATCH] smack: include linux/watch_queue.h

Arnd Bergmann arnd at arndb.de
Mon Sep 9 20:46:25 UTC 2019


In some randconfig builds, the lack of an explicit #include
in smack_lsm.c causes a build failure:

security/smack/smack_lsm.c:4384:7: error: incomplete definition of type 'struct watch_notification'
        if (n->type == WATCH_TYPE_META)
            ~^
include/linux/device.h:46:8: note: forward declaration of 'struct watch_notification'
struct watch_notification;
       ^
security/smack/smack_lsm.c:4384:17: error: use of undeclared identifier 'WATCH_TYPE_META'
        if (n->type == WATCH_TYPE_META)

Fixes: 5301fef8ca60 ("smack: Implement the watch_key and post_notification hooks [untested]")
Signed-off-by: Arnd Bergmann <arnd at arndb.de>
---
 security/smack/smack_lsm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index a15e76489683..5120dd9c6335 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -42,6 +42,7 @@
 #include <linux/parser.h>
 #include <linux/fs_context.h>
 #include <linux/fs_parser.h>
+#include <linux/watch_queue.h>
 #include "smack.h"
 
 #define TRANS_TRUE	"TRUE"
-- 
2.20.0



More information about the Linux-security-module-archive mailing list