[tip: core/rcu] security/safesetid: Replace rcu_swap_protected() with rcu_replace_pointer()

tip-bot2 for Paul E. McKenney tip-bot2 at linutronix.de
Thu Oct 31 11:54:52 UTC 2019


The following commit has been merged into the core/rcu branch of tip:

Commit-ID:     a60a5746004d7dbb68cbccd4c16d0529e2b2d1d9
Gitweb:        https://git.kernel.org/tip/a60a5746004d7dbb68cbccd4c16d0529e2b2d1d9
Author:        Paul E. McKenney <paulmck at kernel.org>
AuthorDate:    Fri, 04 Oct 2019 15:07:09 -07:00
Committer:     Paul E. McKenney <paulmck at kernel.org>
CommitterDate: Wed, 30 Oct 2019 08:45:57 -07:00

security/safesetid: Replace rcu_swap_protected() with rcu_replace_pointer()

This commit replaces the use of rcu_swap_protected() with the more
intuitively appealing rcu_replace_pointer() as a step towards removing
rcu_swap_protected().

Link: https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=Z7-GGtM6wcvtyytXZA1+BHqta4gg6Hw@mail.gmail.com/
Reported-by: Linus Torvalds <torvalds at linux-foundation.org>
Reported-by: Reported-by: kbuild test robot <lkp at intel.com>
[ paulmck: From rcu_replace() to rcu_replace_pointer() per Ingo Molnar. ]
Signed-off-by: Paul E. McKenney <paulmck at kernel.org>
Cc: Micah Morton <mortonm at chromium.org>
Cc: James Morris <jmorris at namei.org>
Cc: "Serge E. Hallyn" <serge at hallyn.com>
Cc: <linux-security-module at vger.kernel.org>
---
 security/safesetid/securityfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/safesetid/securityfs.c b/security/safesetid/securityfs.c
index 74a13d4..f8bc574 100644
--- a/security/safesetid/securityfs.c
+++ b/security/safesetid/securityfs.c
@@ -179,8 +179,8 @@ out_free_rule:
 	 * doesn't currently exist, just use a spinlock for now.
 	 */
 	mutex_lock(&policy_update_lock);
-	rcu_swap_protected(safesetid_setuid_rules, pol,
-			   lockdep_is_held(&policy_update_lock));
+	pol = rcu_replace_pointer(safesetid_setuid_rules, pol,
+				  lockdep_is_held(&policy_update_lock));
 	mutex_unlock(&policy_update_lock);
 	err = len;
 



More information about the Linux-security-module-archive mailing list