security/loadpin: Allow to exclude specific file types
Colin Ian King
colin.king at canonical.com
Fri May 31 10:46:29 UTC 2019
Hi,
Static analysis with Coverity on linux-next has found a potential issue
with the following commit:
commit 1633a4f04cc171fc638deb5c95af96032d3c591b
Author: Ke Wu <mikewu at google.com>
Date: Thu May 30 12:22:08 2019 -0700
security/loadpin: Allow to exclude specific file types
209 for (j = 0; j < ARRAY_SIZE(kernel_read_file_str); j++) {
210 if (strcmp(cur, kernel_read_file_str[j]) == 0) {
211 pr_info("excluding: %s\n",
212 kernel_read_file_str[j]);
CID 81977 (#1 of 1): Out-of-bounds write
overrun-local: Overrunning array ignore_read_file_id of 8 4-byte
elements at element index 8 (byte offset 35) using index j (which
evaluates to 8).
213 ignore_read_file_id[j] = 1;
According to Coverity ignore_read_file_id is an array of 8 integers.
However, ARRAY_SIZE(kernel_read_file_str) is 9, so we have an out of
bounds write on ignore_read_file[j] when j is 8.
Colin
More information about the Linux-security-module-archive
mailing list