[PATCH] smack: remove redundant assignment to variable m

Colin King colin.king at canonical.com
Mon May 27 17:52:26 UTC 2019


From: Colin Ian King <colin.king at canonical.com>

Variable m is assigned a value that is never read and m is later
reassigned in for-loop.  This the assignment is redundant and can
be mored.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 security/smack/smackfs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 47f73a0dabb1..b66adafeb5fa 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -1174,7 +1174,6 @@ static ssize_t smk_write_net4addr(struct file *file, const char __user *buf,
 			rc = -EINVAL;
 			goto free_out;
 		}
-		m = BEBITS;
 		masks = 32;
 	}
 	if (masks > BEBITS) {
-- 
2.20.1



More information about the Linux-security-module-archive mailing list