[PATCH] tomoyo: Swicth from cred->security to task_struct->security.

Tetsuo Handa penguin-kernel at i-love.sakura.ne.jp
Fri Jan 18 17:17:10 UTC 2019


On 2019/01/19 2:01, Casey Schaufler wrote:
>> -/**
>> - * tomoyo_real_domain - Get "struct tomoyo_domain_info" for specified thread.
>> - *
>> - * @task: Pointer to "struct task_struct".
>> + * @task - Pointer to "struct task_struct".
>>   *
>>   * Returns pointer to "struct tomoyo_security" for specified thread.
>>   */
>> -static inline struct tomoyo_domain_info *tomoyo_real_domain(struct task_struct
>> -							    *task)
>> +static inline struct tomoyo_security *tomoyo_security(struct task_struct *task)
> 
> Could you use tomoyo_task() instead of tomoyo_security()?

Possible. But tomoyo_task() might be more confusing because it sounds like
"struct task_struct" when it actually returns "struct task_struct"->security.

Isn't tomoyo_task_security() better if I rename?

> To the extent that it's been possible I've worked to add
> consistency in the security modules, and this breaks it.

Do you want me to rename

/* Structure for "struct task_struct"->security. */
struct tomoyo_security {
	struct tomoyo_domain_info *domain_info;
	struct tomoyo_domain_info *old_domain_info;
};

to "struct tomoyo_task" or "struct tomoyo_task_security" as well?



More information about the Linux-security-module-archive mailing list