[RFC PATCH 02/27] containers: Implement containers as kernel objects

David Howells dhowells at redhat.com
Tue Feb 19 23:13:16 UTC 2019

Eric W. Biederman <ebiederm at xmission.com> wrote:

> > +	c->id = atomic64_inc_return(&container_id_counter);
> This id is not in a namespace, and it doesn't have enough bits
> of entropy to be globally unique.   Not that 64bit is enough
> to have a chance at being globablly unique.

It's in a container, so it doesn't need to be in a namespace.  The intended
purpose is for annotating audit messages.  Globally unique wasn't particularly
in mind.  It could be turned into, say, a uuid, so that isn't really a problem
at this point.

You are right, though, it really should be globally unique as best possible -
even the one in init_container should be.  Ideally, it would look the same
inside the root container as any subcontainer.


More information about the Linux-security-module-archive mailing list