[PATCH v2 13/20] Add set_alias_ function and x86 implementation
Edgecombe, Rick P
rick.p.edgecombe at intel.com
Mon Feb 11 19:27:03 UTC 2019
On Mon, 2019-02-11 at 20:09 +0100, Borislav Petkov wrote:
> On Mon, Jan 28, 2019 at 04:34:15PM -0800, Rick Edgecombe wrote:
> > This adds two new functions set_alias_default_noflush and
> s/This adds/Add/
> > set_alias_nv_noflush for setting the alias mapping for the page to its
> Please end function names with parentheses, below too.
> > default valid permissions and to an invalid state that cannot be cached in
> > a TLB, respectively. These functions to not flush the TLB.
> Also, pls put that description as comments over the functions in the
> code. Otherwise that "nv" as part of the name doesn't really explain
> what it does.
> Actually, you could just as well call the function
> All the other words are written in full, no need to have "nv" there.
Yes, that seems better.
More information about the Linux-security-module-archive