[PATCH v2 11/20] x86/jump-label: remove support for custom poker
bp at alien8.de
Mon Feb 11 18:37:50 UTC 2019
On Mon, Jan 28, 2019 at 04:34:13PM -0800, Rick Edgecombe wrote:
> From: Nadav Amit <namit at vmware.com>
> There are only two types of poking: early and breakpoint based. The use
> of a function pointer to perform poking complicates the code and is
> probably inefficient due to the use of indirect branches.
> Cc: Andy Lutomirski <luto at kernel.org>
> Cc: Kees Cook <keescook at chromium.org>
> Cc: Dave Hansen <dave.hansen at intel.com>
> Cc: Masami Hiramatsu <mhiramat at kernel.org>
> Acked-by: Peter Zijlstra (Intel) <peterz at infradead.org>
> Signed-off-by: Nadav Amit <namit at vmware.com>
> Signed-off-by: Rick Edgecombe <rick.p.edgecombe at intel.com>
> arch/x86/kernel/jump_label.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
> @@ -80,16 +71,17 @@ static void __ref __jump_label_transform(struct jump_entry *entry,
> bug_at((void *)jump_entry_code(entry), line);
> - * Make text_poke_bp() a default fallback poker.
> + * As long as we're UP and not yet marked RO, we can use
> + * text_poke_early; SYSTEM_BOOTING guarantees both, as we switch to
> + * SYSTEM_SCHEDULING before going either.
Good mailing practices for 400: avoid top-posting and trim the reply.
More information about the Linux-security-module-archive