[PATCH V40 03/29] security: Add a static lockdown policy LSM

David Howells dhowells at redhat.com
Fri Aug 30 16:28:26 UTC 2019


Matthew Garrett <matthewgarrett at google.com> wrote:

> +static char *lockdown_reasons[LOCKDOWN_CONFIDENTIALITY_MAX+1] = {

const char *const maybe?

> +static enum lockdown_reason lockdown_levels[] = {LOCKDOWN_NONE,
> +						 LOCKDOWN_INTEGRITY_MAX,
> +						 LOCKDOWN_CONFIDENTIALITY_MAX};
> +

const?

Isn't this also a 1:1 mapping?

> +static int lock_kernel_down(const char *where, enum lockdown_reason level)

Is the last parameter the reason or the level?  You're mixing the terms.

David



More information about the Linux-security-module-archive mailing list