[PATCH v3 18/20] tpm: use u32 instead of int for pcr index

Jarkko Sakkinen jarkko.sakkinen at linux.intel.com
Wed Sep 19 15:22:19 UTC 2018


On Tue, Sep 18, 2018 at 12:34:57PM +0300, Tomas Winkler wrote:
> TPM pcr indices cannot be negative, also the tpm
> commands accept u32 number as a pcr index.
> 
> 1. Adjust the API to use u32 instead of int in all pcr related
> functions.

NAK.

> 2. Rename tpm1_pcr_read_dev to tpm1_pcr_read() to match
> the counterpart tpm2_pcr_read()

I would accept this a separate commit (and it should be a separate).

> 3. Remove redundant constants in tpm1_pcr_extend() function.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler at intel.com>

/Jarkko



More information about the Linux-security-module-archive mailing list