[PATCH] tpm: tpm_try_transmit() refactor error flow.

Winkler, Tomas tomas.winkler at intel.com
Thu Oct 18 06:06:23 UTC 2018



> -----Original Message-----
> From: Jarkko Sakkinen [mailto:jarkko.sakkinen at linux.intel.com]
> Sent: Thursday, October 18, 2018 03:15
> To: Winkler, Tomas <tomas.winkler at intel.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen at linux.intel.com>; Jason Gunthorpe
> <jgg at ziepe.ca>; Nayna Jain <nayna at linux.vnet.ibm.com>; Usyskin,
> Alexander <alexander.usyskin at intel.com>; Struk, Tadeusz
> <tadeusz.struk at intel.com>; linux-integrity at vger.kernel.org; linux-security-
> module at vger.kernel.org; linux-kernel at vger.kernel.org;
> stable at vger.kernel.org
> Subject: Re: [PATCH] tpm: tpm_try_transmit() refactor error flow.
> 
> On Tue, 16 Oct 2018, Tomas Winkler wrote:
> > First, rename out_no_locality to out_locality for bailing out on both
> > tpm_cmd_ready() and tpm_request_locality() failure.
> 
> This is unnecessary change and technically it is not a rename: the commit
> message text and the code change do not match. Rename is just a rename
> (i.e. change a variable name foo to bar).

I'm renaming the label because it doesn't match the code flow anymore,
I can change the commit message, but you please review the code.
Tomas






More information about the Linux-security-module-archive mailing list