[PATCH v8 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit()
Jarkko Sakkinen
jarkko.sakkinen at linux.intel.com
Sun Nov 18 07:36:18 UTC 2018
On Fri, Nov 16, 2018 at 11:19:57AM -0500, Sasha Levin wrote:
> On Fri, Nov 16, 2018 at 02:38:32PM +0200, Jarkko Sakkinen wrote:
> > Always call tpm2_flush_space() on failure in tpm_try_transmit() so that
> > the volatile memory of the TPM gets cleared. If /dev/tpm0 does not have
> > sufficient permissions (usually it has), this could lead to the leakage
> > of TPM objects. Through /dev/tpmrm0 this issue does not raise any new
> > security concerns.
> >
> > Cc: James Bottomley <James.Bottomley at HansenPartnership.com>
> > Cc: stable at vger.kernel.org
> > Fixes: 745b361e989a ("tpm:tpm: infrastructure for TPM spaces")
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen at linux.intel.com>
> > Reviewed-by: Stefan Berger <stefanb at linux.ibm.com>
>
> Hi Jarkko,
>
> This patch seems to depend on previous patches in this series, but those
> were not tagged for stable. Do they also need to be backported? If so,
> can you tag them as such?
Hi
Is that the preferred approach?
I've usually followed this workflow:
1. Mark patches with a fix to a regression with the fixes tag.
2. If a merge conflict raises, I'll locate the deps.
I've done it this way because often patches can depend on patches
outside the patch set. Anyway, I'm open to change my workflow if
that is required.
/Jarkko
More information about the Linux-security-module-archive
mailing list