[PATCH v7 1/6] security: Move LSM registration arguments to struct lsm_info

James Morris jmorris at namei.org
Tue May 1 18:34:24 UTC 2018


On Wed, 25 Apr 2018, Sargun Dhillon wrote:

> +	/* This field is not currently in use */
> +	struct lsm_info			*info;

It does seem to be in use.

>  static const struct file_operations lsm_ops = {
> -	.read = lsm_read,
> -	.llseek = generic_file_llseek,
> +	.open		= lsm_ops_open,
> +	.read		= seq_read,
> +	.llseek		= seq_lseek,
> +	.release	= seq_release,
>  };

Please mention this change in the changelog, or probably better, make it a 
separate patch.


-- 
James Morris
<jmorris at namei.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the Linux-security-module-archive mailing list