[PATCH] Smack: Fix memory leak in smack_inode_getsecctx
CHANDAN VN
chandan.vn at samsung.com
Tue Jun 5 14:46:50 UTC 2018
>On 6/5/2018 12:04 AM, CHANDAN VN wrote:
>>
>>
>>> On Mon, Jun 04, 2018 at 02:01:34PM -0700, Casey Schaufler wrote:
>>>> On 6/1/2018 10:45 AM, Casey Schaufler wrote:
>>>> > Fix memory leak in smack_inode_getsecctx
>>>> >
>>>> > The implementation of smack_inode_getsecctx() made
>>>> > incorrect assumptions about how Smack presents a security
>>>> > context. Smack does not need to allocate memory to support
>>>> > security contexts, so "releasing" a Smack context is a no-op.
>>>> > The code made an unnecessary copy and returned that as a
>>>> > context, which was never freed. The revised implementation
>>>> > returns the context correctly.
>>>> >
>>>> > Signed-off-by: Casey Schaufler <casey at schaufler-ca.com>
>>>>
>>>> Tejun, does this pass your tests?
>>
>>> Oh, I'm not the one who reported. Chandan?
>> Looks good to me. Leak not found.
>
>Thanks. Can I add your "Tested-by:" on the commit?
Sure. I think "Reported-by:" would also be ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the Linux-security-module-archive
mailing list