[PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring

Eric Biggers ebiggers3 at gmail.com
Fri Nov 24 20:37:50 UTC 2017


On Fri, Nov 24, 2017 at 03:52:05PM +0000, David Howells wrote:
> Eric Biggers <ebiggers3 at gmail.com> wrote:
> 
> > -			construct_get_dest_keyring(&dest_keyring);
> 
> This will break.  construct_get_dest_keyring() does other things than just
> getting a ref on whatever dest_keyring points to.
> 

Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in this
case.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the Linux-security-module-archive mailing list