[PATCH v7 2/9] IB/core: Enforce PKey security on QPs

James Morris jmorris at namei.org
Mon May 22 00:13:16 UTC 2017


On Fri, 19 May 2017, Dan Jurgens wrote:

> security/security.c                  | 385 ++++++++++++++++++++++

This looks wrong -- merge problem?


> +	if (pps->alt.state != IB_PORT_PKEY_NOT_VALID) {
> +		get_pkey_and_subnet_prefix(&pps->alt,
> +					   &pkey,
> +					   &subnet_prefix);
> +
> +		ret = enforce_qp_pkey_security(pkey,
> +					       subnet_prefix,
> +					       sec);
> +	}
> +
> +	if (ret)
> +		goto out;

The above if/goto is unnecessary.

> +
> +out:
> +	return ret;
> +}



-- 
James Morris
<jmorris at namei.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the Linux-security-module-archive mailing list