selinux: Delete an error message for a failed memory allocation in policydb_read()
SF Markus Elfring
elfring at users.sourceforge.net
Fri Mar 24 12:13:09 UTC 2017
>> Omit an extra message for a memory allocation failure in this function.
>>
>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
>> Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
>> ---
>> security/selinux/ss/policydb.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> I'm not going to remove an error message without some better reasoning
> in the patch description. Providing a link to slides is fine, but
> your commit message needs to convey the important information and I
> don't think that is the case here (what happens when that URL dies?).
Do you need an explicit reminder there that the function “kmalloc” provides its own
error reporting already because the flag “__GFP_NOWARN” was not passed here?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the Linux-security-module-archive
mailing list