[PATCH] xattr: fix kstrdup.cocci warnings
kbuild test robot
lkp at intel.com
Sat Jun 24 21:02:24 UTC 2017
fs/xattr.c:516:10-17: WARNING opportunity for kstrdep (strcpy on line 519)
Use kstrdup rather than duplicating its implementation
Generated by: scripts/coccinelle/api/kstrdup.cocci
CC: Stefan Berger <stefanb at linux.vnet.ibm.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---
xattr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -513,10 +513,9 @@ xattr_userns_name(const char *fullname,
return buffer;
out_copy:
- buffer = kmalloc(strlen(suffix) + 1, GFP_KERNEL);
+ buffer = kstrdup(suffix, GFP_KERNEL);
if (!buffer)
return ERR_PTR(-ENOMEM);
- strcpy(buffer, suffix);
return buffer;
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the Linux-security-module-archive
mailing list