[PATCH 1/4] selinux: Delete eight unnecessary variable assignments

Serge E. Hallyn serge at hallyn.com
Sun Aug 13 16:24:14 UTC 2017


Quoting Serge E. Hallyn (serge at hallyn.com):
> Quoting SF Markus Elfring (elfring at users.sourceforge.net):
> > From: Markus Elfring <elfring at users.sourceforge.net>
> > Date: Sun, 13 Aug 2017 14:17:48 +0200
> > 
> > One local variable was reset to zero at the end of these functions.
> > This value will also be set by a previous call of a function if it was
> > executed successfully. Thus omit an extra assignment there.
> > 
> > Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
> 
> Acked-by: Serge Hallyn <serge at hallyn.com>

BTW this does add a burden to the maintainers as it makes the
code a bit more fragile in the face of future changes.  So my
ack means it looks ok, but if the maintainers don't want to take
it I absolutely understand.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the Linux-security-module-archive mailing list