[PATCH v4 06/15] smack: Refactor to remove bprm_secureexec hook

James Morris jmorris at namei.org
Tue Aug 1 00:46:59 UTC 2017


On Mon, 31 Jul 2017, Kees Cook wrote:

> The Smack bprm_secureexec hook can be merged with the bprm_set_creds
> hook since it's dealing with the same information, and all of the details
> are finalized during the first call to the bprm_set_creds hook via
> prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored
> via bprm->called_set_creds).
> 
> Here, the test can just happen at the end of the bprm_set_creds hook,
> and the bprm_secureexec hook can be dropped.
> 
> Cc: Casey Schaufler <casey at schaufler-ca.com>
> Signed-off-by: Kees Cook <keescook at chromium.org>
> Acked-by: Serge Hallyn <serge at hallyn.com>
> ---
>  security/smack/smack_lsm.c | 21 ++++-----------------
>  1 file changed, 4 insertions(+), 17 deletions(-)


Reviewed-by: James Morris <james.l.morris at oracle.com>


-- 
James Morris
<jmorris at namei.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the Linux-security-module-archive mailing list